Compare commits
3 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
 root
|
84d69cad92 | ||
 m.schnitzler
|
30aa53c049 | ||
|
root
|
e5c2b7d428 |
Generated
+71
-71
@@ -1,19 +1,19 @@
|
||||
{
|
||||
"name": "vscodestat",
|
||||
"version": "1.1.159",
|
||||
"version": "1.1.160",
|
||||
"lockfileVersion": 3,
|
||||
"requires": true,
|
||||
"packages": {
|
||||
"": {
|
||||
"name": "vscodestat",
|
||||
"version": "1.1.159",
|
||||
"version": "1.1.160",
|
||||
"license": "ISC",
|
||||
"devDependencies": {
|
||||
"@types/mocha": "^10.0.10",
|
||||
"@types/node": "25.x",
|
||||
"@types/vscode": "^1.116.0",
|
||||
"@typescript-eslint/eslint-plugin": "^8.59.0",
|
||||
"@typescript-eslint/parser": "^8.59.0",
|
||||
"@typescript-eslint/eslint-plugin": "^8.59.1",
|
||||
"@typescript-eslint/parser": "^8.59.1",
|
||||
"@vscode/test-cli": "^0.0.12",
|
||||
"@vscode/test-electron": "^2.5.2",
|
||||
"eslint": "^10.1.0",
|
||||
@@ -317,17 +317,17 @@
|
||||
"license": "MIT"
|
||||
},
|
||||
"node_modules/@typescript-eslint/eslint-plugin": {
|
||||
"version": "8.59.0",
|
||||
"resolved": "https://registry.npmjs.org/@typescript-eslint/eslint-plugin/-/eslint-plugin-8.59.0.tgz",
|
||||
"integrity": "sha512-HyAZtpdkgZwpq8Sz3FSUvCR4c+ScbuWa9AksK2Jweub7w4M3yTz4O11AqVJzLYjy/B9ZWPyc81I+mOdJU/bDQw==",
|
||||
"version": "8.59.1",
|
||||
"resolved": "https://registry.npmjs.org/@typescript-eslint/eslint-plugin/-/eslint-plugin-8.59.1.tgz",
|
||||
"integrity": "sha512-BOziFIfE+6osHO9FoJG4zjoHUcvI7fTNBSpdAwrNH0/TLvzjsk2oo8XSSOT2HhqUyhZPfHv4UOffoJ9oEEQ7Ag==",
|
||||
"dev": true,
|
||||
"license": "MIT",
|
||||
"dependencies": {
|
||||
"@eslint-community/regexpp": "^4.12.2",
|
||||
"@typescript-eslint/scope-manager": "8.59.0",
|
||||
"@typescript-eslint/type-utils": "8.59.0",
|
||||
"@typescript-eslint/utils": "8.59.0",
|
||||
"@typescript-eslint/visitor-keys": "8.59.0",
|
||||
"@typescript-eslint/scope-manager": "8.59.1",
|
||||
"@typescript-eslint/type-utils": "8.59.1",
|
||||
"@typescript-eslint/utils": "8.59.1",
|
||||
"@typescript-eslint/visitor-keys": "8.59.1",
|
||||
"ignore": "^7.0.5",
|
||||
"natural-compare": "^1.4.0",
|
||||
"ts-api-utils": "^2.5.0"
|
||||
@@ -340,22 +340,22 @@
|
||||
"url": "https://opencollective.com/typescript-eslint"
|
||||
},
|
||||
"peerDependencies": {
|
||||
"@typescript-eslint/parser": "^8.59.0",
|
||||
"@typescript-eslint/parser": "^8.59.1",
|
||||
"eslint": "^8.57.0 || ^9.0.0 || ^10.0.0",
|
||||
"typescript": ">=4.8.4 <6.1.0"
|
||||
}
|
||||
},
|
||||
"node_modules/@typescript-eslint/parser": {
|
||||
"version": "8.59.0",
|
||||
"resolved": "https://registry.npmjs.org/@typescript-eslint/parser/-/parser-8.59.0.tgz",
|
||||
"integrity": "sha512-TI1XGwKbDpo9tRW8UDIXCOeLk55qe9ZFGs8MTKU6/M08HWTw52DD/IYhfQtOEhEdPhLMT26Ka/x7p70nd3dzDg==",
|
||||
"version": "8.59.1",
|
||||
"resolved": "https://registry.npmjs.org/@typescript-eslint/parser/-/parser-8.59.1.tgz",
|
||||
"integrity": "sha512-HDQH9O/47Dxi1ceDhBXdaldtf/WV9yRYMjbjCuNk3qnaTD564qwv61Y7+gTxwxRKzSrgO5uhtw584igXVuuZkA==",
|
||||
"dev": true,
|
||||
"license": "MIT",
|
||||
"dependencies": {
|
||||
"@typescript-eslint/scope-manager": "8.59.0",
|
||||
"@typescript-eslint/types": "8.59.0",
|
||||
"@typescript-eslint/typescript-estree": "8.59.0",
|
||||
"@typescript-eslint/visitor-keys": "8.59.0",
|
||||
"@typescript-eslint/scope-manager": "8.59.1",
|
||||
"@typescript-eslint/types": "8.59.1",
|
||||
"@typescript-eslint/typescript-estree": "8.59.1",
|
||||
"@typescript-eslint/visitor-keys": "8.59.1",
|
||||
"debug": "^4.4.3"
|
||||
},
|
||||
"engines": {
|
||||
@@ -371,14 +371,14 @@
|
||||
}
|
||||
},
|
||||
"node_modules/@typescript-eslint/project-service": {
|
||||
"version": "8.59.0",
|
||||
"resolved": "https://registry.npmjs.org/@typescript-eslint/project-service/-/project-service-8.59.0.tgz",
|
||||
"integrity": "sha512-Lw5ITrR5s5TbC19YSvlr63ZfLaJoU6vtKTHyB0GQOpX0W7d5/Ir6vUahWi/8Sps/nOukZQ0IB3SmlxZnjaKVnw==",
|
||||
"version": "8.59.1",
|
||||
"resolved": "https://registry.npmjs.org/@typescript-eslint/project-service/-/project-service-8.59.1.tgz",
|
||||
"integrity": "sha512-+MuHQlHiEr00Of/IQbE/MmEoi44znZHbR/Pz7Opq4HryUOlRi+/44dro9Ycy8Fyo+/024IWtw8m4JUMCGTYxDg==",
|
||||
"dev": true,
|
||||
"license": "MIT",
|
||||
"dependencies": {
|
||||
"@typescript-eslint/tsconfig-utils": "^8.59.0",
|
||||
"@typescript-eslint/types": "^8.59.0",
|
||||
"@typescript-eslint/tsconfig-utils": "^8.59.1",
|
||||
"@typescript-eslint/types": "^8.59.1",
|
||||
"debug": "^4.4.3"
|
||||
},
|
||||
"engines": {
|
||||
@@ -393,14 +393,14 @@
|
||||
}
|
||||
},
|
||||
"node_modules/@typescript-eslint/scope-manager": {
|
||||
"version": "8.59.0",
|
||||
"resolved": "https://registry.npmjs.org/@typescript-eslint/scope-manager/-/scope-manager-8.59.0.tgz",
|
||||
"integrity": "sha512-UzR16Ut8IpA3Mc4DbgAShlPPkVm8xXMWafXxB0BocaVRHs8ZGakAxGRskF7FId3sdk9lgGD73GSFaWmWFDE4dg==",
|
||||
"version": "8.59.1",
|
||||
"resolved": "https://registry.npmjs.org/@typescript-eslint/scope-manager/-/scope-manager-8.59.1.tgz",
|
||||
"integrity": "sha512-LwuHQI4pDOYVKvmH2dkaJo6YZCSgouVgnS/z7yBPKBMvgtBvyLqiLy9Z6b7+m/TRcX1NFYUqZetI5Y+aT4GEfg==",
|
||||
"dev": true,
|
||||
"license": "MIT",
|
||||
"dependencies": {
|
||||
"@typescript-eslint/types": "8.59.0",
|
||||
"@typescript-eslint/visitor-keys": "8.59.0"
|
||||
"@typescript-eslint/types": "8.59.1",
|
||||
"@typescript-eslint/visitor-keys": "8.59.1"
|
||||
},
|
||||
"engines": {
|
||||
"node": "^18.18.0 || ^20.9.0 || >=21.1.0"
|
||||
@@ -411,9 +411,9 @@
|
||||
}
|
||||
},
|
||||
"node_modules/@typescript-eslint/tsconfig-utils": {
|
||||
"version": "8.59.0",
|
||||
"resolved": "https://registry.npmjs.org/@typescript-eslint/tsconfig-utils/-/tsconfig-utils-8.59.0.tgz",
|
||||
"integrity": "sha512-91Sbl3s4Kb3SybliIY6muFBmHVv+pYXfybC4Oolp3dvk8BvIE3wOPc+403CWIT7mJNkfQRGtdqghzs2+Z91Tqg==",
|
||||
"version": "8.59.1",
|
||||
"resolved": "https://registry.npmjs.org/@typescript-eslint/tsconfig-utils/-/tsconfig-utils-8.59.1.tgz",
|
||||
"integrity": "sha512-/0nEyPbX7gRsk0Uwfe4ALwwgxuA66d/l2mhRDNlAvaj4U3juhUtJNq0DsY8M2AYwwb9rEq2hrC3IcIcEt++iJA==",
|
||||
"dev": true,
|
||||
"license": "MIT",
|
||||
"engines": {
|
||||
@@ -428,15 +428,15 @@
|
||||
}
|
||||
},
|
||||
"node_modules/@typescript-eslint/type-utils": {
|
||||
"version": "8.59.0",
|
||||
"resolved": "https://registry.npmjs.org/@typescript-eslint/type-utils/-/type-utils-8.59.0.tgz",
|
||||
"integrity": "sha512-3TRiZaQSltGqGeNrJzzr1+8YcEobKH9rHnqIp/1psfKFmhRQDNMGP5hBufanYTGznwShzVLs3Mz+gDN7HkWfXg==",
|
||||
"version": "8.59.1",
|
||||
"resolved": "https://registry.npmjs.org/@typescript-eslint/type-utils/-/type-utils-8.59.1.tgz",
|
||||
"integrity": "sha512-klWPBR2ciQHS3f++ug/mVnWKPjBUo7icEL3FAO1lhAR1Z1i5NQYZ1EannMSRYcq5qCv5wNALlXr6fksRHyYl7w==",
|
||||
"dev": true,
|
||||
"license": "MIT",
|
||||
"dependencies": {
|
||||
"@typescript-eslint/types": "8.59.0",
|
||||
"@typescript-eslint/typescript-estree": "8.59.0",
|
||||
"@typescript-eslint/utils": "8.59.0",
|
||||
"@typescript-eslint/types": "8.59.1",
|
||||
"@typescript-eslint/typescript-estree": "8.59.1",
|
||||
"@typescript-eslint/utils": "8.59.1",
|
||||
"debug": "^4.4.3",
|
||||
"ts-api-utils": "^2.5.0"
|
||||
},
|
||||
@@ -453,9 +453,9 @@
|
||||
}
|
||||
},
|
||||
"node_modules/@typescript-eslint/types": {
|
||||
"version": "8.59.0",
|
||||
"resolved": "https://registry.npmjs.org/@typescript-eslint/types/-/types-8.59.0.tgz",
|
||||
"integrity": "sha512-nLzdsT1gdOgFxxxwrlNVUBzSNBEEHJ86bblmk4QAS6stfig7rcJzWKqCyxFy3YRRHXDWEkb2NralA1nOYkkm/A==",
|
||||
"version": "8.59.1",
|
||||
"resolved": "https://registry.npmjs.org/@typescript-eslint/types/-/types-8.59.1.tgz",
|
||||
"integrity": "sha512-ZDCjgccSdYPw5Bxh+my4Z0lJU96ZDN7jbBzvmEn0FZx3RtU1C7VWl6NbDx94bwY3V5YsgwRzJPOgeY2Q/nLG8A==",
|
||||
"dev": true,
|
||||
"license": "MIT",
|
||||
"engines": {
|
||||
@@ -467,16 +467,16 @@
|
||||
}
|
||||
},
|
||||
"node_modules/@typescript-eslint/typescript-estree": {
|
||||
"version": "8.59.0",
|
||||
"resolved": "https://registry.npmjs.org/@typescript-eslint/typescript-estree/-/typescript-estree-8.59.0.tgz",
|
||||
"integrity": "sha512-O9Re9P1BmBLFJyikRbQpLku/QA3/AueZNO9WePLBwQrvkixTmDe8u76B6CYUAITRl/rHawggEqUGn5QIkVRLMw==",
|
||||
"version": "8.59.1",
|
||||
"resolved": "https://registry.npmjs.org/@typescript-eslint/typescript-estree/-/typescript-estree-8.59.1.tgz",
|
||||
"integrity": "sha512-OUd+vJS05sSkOip+BkZ/2NS8RMxrAAJemsC6vU3kmfLyeaJT0TftHkV9mcx2107MmsBVXXexhVu4F0TZXyMl4g==",
|
||||
"dev": true,
|
||||
"license": "MIT",
|
||||
"dependencies": {
|
||||
"@typescript-eslint/project-service": "8.59.0",
|
||||
"@typescript-eslint/tsconfig-utils": "8.59.0",
|
||||
"@typescript-eslint/types": "8.59.0",
|
||||
"@typescript-eslint/visitor-keys": "8.59.0",
|
||||
"@typescript-eslint/project-service": "8.59.1",
|
||||
"@typescript-eslint/tsconfig-utils": "8.59.1",
|
||||
"@typescript-eslint/types": "8.59.1",
|
||||
"@typescript-eslint/visitor-keys": "8.59.1",
|
||||
"debug": "^4.4.3",
|
||||
"minimatch": "^10.2.2",
|
||||
"semver": "^7.7.3",
|
||||
@@ -495,16 +495,16 @@
|
||||
}
|
||||
},
|
||||
"node_modules/@typescript-eslint/utils": {
|
||||
"version": "8.59.0",
|
||||
"resolved": "https://registry.npmjs.org/@typescript-eslint/utils/-/utils-8.59.0.tgz",
|
||||
"integrity": "sha512-I1R/K7V07XsMJ12Oaxg/O9GfrysGTmCRhvZJBv0RE0NcULMzjqVpR5kRRQjHsz3J/bElU7HwCO7zkqL+MSUz+g==",
|
||||
"version": "8.59.1",
|
||||
"resolved": "https://registry.npmjs.org/@typescript-eslint/utils/-/utils-8.59.1.tgz",
|
||||
"integrity": "sha512-3pIeoXhCeYH9FSCBI8P3iNwJlGuzPlYKkTlen2O9T1DSeeg8UG8jstq6BLk+Mda0qup7mgk4z4XL4OzRaxZ8LA==",
|
||||
"dev": true,
|
||||
"license": "MIT",
|
||||
"dependencies": {
|
||||
"@eslint-community/eslint-utils": "^4.9.1",
|
||||
"@typescript-eslint/scope-manager": "8.59.0",
|
||||
"@typescript-eslint/types": "8.59.0",
|
||||
"@typescript-eslint/typescript-estree": "8.59.0"
|
||||
"@typescript-eslint/scope-manager": "8.59.1",
|
||||
"@typescript-eslint/types": "8.59.1",
|
||||
"@typescript-eslint/typescript-estree": "8.59.1"
|
||||
},
|
||||
"engines": {
|
||||
"node": "^18.18.0 || ^20.9.0 || >=21.1.0"
|
||||
@@ -519,13 +519,13 @@
|
||||
}
|
||||
},
|
||||
"node_modules/@typescript-eslint/visitor-keys": {
|
||||
"version": "8.59.0",
|
||||
"resolved": "https://registry.npmjs.org/@typescript-eslint/visitor-keys/-/visitor-keys-8.59.0.tgz",
|
||||
"integrity": "sha512-/uejZt4dSere1bx12WLlPfv8GktzcaDtuJ7s42/HEZ5zGj9oxRaD4bj7qwSunXkf+pbAhFt2zjpHYUiT5lHf0Q==",
|
||||
"version": "8.59.1",
|
||||
"resolved": "https://registry.npmjs.org/@typescript-eslint/visitor-keys/-/visitor-keys-8.59.1.tgz",
|
||||
"integrity": "sha512-LdDNl6C5iJExcM0Yh0PwAIBb9PrSiCsWamF/JyEZawm3kFDnRoaq3LGE4bpyRao/fWeGKKyw7icx0YxrLFC5Cg==",
|
||||
"dev": true,
|
||||
"license": "MIT",
|
||||
"dependencies": {
|
||||
"@typescript-eslint/types": "8.59.0",
|
||||
"@typescript-eslint/types": "8.59.1",
|
||||
"eslint-visitor-keys": "^5.0.0"
|
||||
},
|
||||
"engines": {
|
||||
@@ -657,9 +657,9 @@
|
||||
}
|
||||
},
|
||||
"node_modules/ajv": {
|
||||
"version": "6.14.0",
|
||||
"resolved": "https://registry.npmjs.org/ajv/-/ajv-6.14.0.tgz",
|
||||
"integrity": "sha512-IWrosm/yrn43eiKqkfkHis7QioDleaXQHdDVPKg0FSwwd/DuvyX79TZnFOnYpB7dcsFAMmtFztZuXPDvSePkFw==",
|
||||
"version": "6.15.0",
|
||||
"resolved": "https://registry.npmjs.org/ajv/-/ajv-6.15.0.tgz",
|
||||
"integrity": "sha512-fgFx7Hfoq60ytK2c7DhnF8jIvzYgOMxfugjLOSMHjLIPgenqa7S7oaagATUq99mV6IYvN2tRmC0wnTYX6iPbMw==",
|
||||
"dev": true,
|
||||
"license": "MIT",
|
||||
"dependencies": {
|
||||
@@ -944,9 +944,9 @@
|
||||
}
|
||||
},
|
||||
"node_modules/cli-truncate/node_modules/string-width": {
|
||||
"version": "8.2.0",
|
||||
"resolved": "https://registry.npmjs.org/string-width/-/string-width-8.2.0.tgz",
|
||||
"integrity": "sha512-6hJPQ8N0V0P3SNmP6h2J99RLuzrWz2gvT7VnK5tKvrNqJoyS9W4/Fb8mo31UiPvy00z7DQXkP2hnKBVav76thw==",
|
||||
"version": "8.2.1",
|
||||
"resolved": "https://registry.npmjs.org/string-width/-/string-width-8.2.1.tgz",
|
||||
"integrity": "sha512-IIaP0g3iy9Cyy18w3M9YcaDudujEAVHKt3a3QJg1+sr/oX96TbaGUubG0hJyCjCBThFH+tFpcIyoUHUn1ogaLA==",
|
||||
"dev": true,
|
||||
"license": "MIT",
|
||||
"dependencies": {
|
||||
@@ -1177,14 +1177,14 @@
|
||||
"license": "MIT"
|
||||
},
|
||||
"node_modules/enhanced-resolve": {
|
||||
"version": "5.20.1",
|
||||
"resolved": "https://registry.npmjs.org/enhanced-resolve/-/enhanced-resolve-5.20.1.tgz",
|
||||
"integrity": "sha512-Qohcme7V1inbAfvjItgw0EaxVX5q2rdVEZHRBrEQdRZTssLDGsL8Lwrznl8oQ/6kuTJONLaDcGjkNP247XEhcA==",
|
||||
"version": "5.21.0",
|
||||
"resolved": "https://registry.npmjs.org/enhanced-resolve/-/enhanced-resolve-5.21.0.tgz",
|
||||
"integrity": "sha512-otxSQPw4lkOZWkHpB3zaEQs6gWYEsmX4xQF68ElXC/TWvGxGMSGOvoNbaLXm6/cS/fSfHtsEdw90y20PCd+sCA==",
|
||||
"dev": true,
|
||||
"license": "MIT",
|
||||
"dependencies": {
|
||||
"graceful-fs": "^4.2.4",
|
||||
"tapable": "^2.3.0"
|
||||
"tapable": "^2.3.3"
|
||||
},
|
||||
"engines": {
|
||||
"node": ">=10.13.0"
|
||||
@@ -3109,9 +3109,9 @@
|
||||
}
|
||||
},
|
||||
"node_modules/tapable": {
|
||||
"version": "2.3.2",
|
||||
"resolved": "https://registry.npmjs.org/tapable/-/tapable-2.3.2.tgz",
|
||||
"integrity": "sha512-1MOpMXuhGzGL5TTCZFItxCc0AARf1EZFQkGqMm7ERKj8+Hgr5oLvJOVFcC+lRmR8hCe2S3jC4T5D7Vg/d7/fhA==",
|
||||
"version": "2.3.3",
|
||||
"resolved": "https://registry.npmjs.org/tapable/-/tapable-2.3.3.tgz",
|
||||
"integrity": "sha512-uxc/zpqFg6x7C8vOE7lh6Lbda8eEL9zmVm/PLeTPBRhh1xCgdWaQ+J1CUieGpIfm2HdtsUpRv+HshiasBMcc6A==",
|
||||
"dev": true,
|
||||
"license": "MIT",
|
||||
"engines": {
|
||||
|
||||
+3
-3
@@ -1,7 +1,7 @@
|
||||
{
|
||||
"name": "vscodestat",
|
||||
"displayName": "vscodestat",
|
||||
"version": "1.1.159",
|
||||
"version": "1.1.160",
|
||||
"description": "",
|
||||
"categories": [
|
||||
"Other"
|
||||
@@ -56,8 +56,8 @@
|
||||
"@types/mocha": "^10.0.10",
|
||||
"@types/node": "25.x",
|
||||
"@types/vscode": "^1.116.0",
|
||||
"@typescript-eslint/eslint-plugin": "^8.59.0",
|
||||
"@typescript-eslint/parser": "^8.59.0",
|
||||
"@typescript-eslint/eslint-plugin": "^8.59.1",
|
||||
"@typescript-eslint/parser": "^8.59.1",
|
||||
"@vscode/test-cli": "^0.0.12",
|
||||
"@vscode/test-electron": "^2.5.2",
|
||||
"eslint": "^10.1.0",
|
||||
|
||||
@@ -0,0 +1,144 @@
|
||||
REVIEW DE CODE — 2026-04-26
|
||||
============================================
|
||||
|
||||
Extension VSCode (TypeScript) qui collecte des metriques sur
|
||||
l'activite du user dans VSCode :
|
||||
- ouverture de fichier / changement d'onglet (event 'open')
|
||||
- sauvegarde de fichier (event 'save')
|
||||
- focus/blur de la fenetre (event 'focus')
|
||||
|
||||
Envoie un POST JSON a la URL configuree (`vscodestat.url`).
|
||||
113 lignes TypeScript, version 1.1.159 (vsix 1.1.141 commit).
|
||||
|
||||
NB : extension force-installed dans les containers vscode + vscodeluigi
|
||||
(cf vscode/todo.txt). C'est l'extension de monitoring activite dev.
|
||||
|
||||
SECURITE
|
||||
--------
|
||||
[ ] vscodestat.url configurable user-side (CRITIQUE pour exfil)
|
||||
src/extension.ts:14-23 : commande `setUrl` permet au user de
|
||||
changer l'URL en runtime via `vscode.workspace.getConfiguration
|
||||
().update('vscodestat.url', url, ConfigurationTarget.Global)`.
|
||||
Le user peut donc rediriger ses metriques vers son propre
|
||||
serveur. Dans le contexte (extension force-installed pour
|
||||
tracking employe), le user peut bypass le tracking en
|
||||
pointant sur `https://localhost/dummy` ou similar. Attendu /
|
||||
pas attendu ?
|
||||
NB : entrypoint.sh dans vscode/ overwrite la URL a chaque
|
||||
boot du container. Donc tracking restored. Mais pendant la
|
||||
session, user peut tweak. A documenter le comportement.
|
||||
|
||||
[ ] makeHttpRequest envoie au serveur l'event sans auth (RGPD)
|
||||
src/extension.ts:97-118 : `fetch(url, { method: 'POST',
|
||||
headers: ..., body: JSON.stringify(json) })`. Pas de token.
|
||||
Cote serveur (cf monitoringserver/todo.txt), `/vscodestat` est
|
||||
aussi sans auth => tout le monde peut envoyer des metriques.
|
||||
Mais ici c'est cote client, le code est legitime. Ce qui est
|
||||
discutable c'est que l'event contient :
|
||||
- `event: 'open'`, `project: extractProjectName(filePath)`
|
||||
Ces donnees sont des metadonnees d'activite du salarie. RGPD
|
||||
: doit etre dans le declaration des traitements RH.
|
||||
|
||||
[ ] extractProjectName fuite des paths potentiellement sensibles
|
||||
src/extension.ts:73-81 :
|
||||
const match = path.match(/\/docker\/([^/]+)/);
|
||||
if (match) return match[1];
|
||||
Si un user ouvre un fichier hors `/docker/X/...`, le
|
||||
`extractProjectName` retourne null, donc `project: null`
|
||||
envoye. Pas un leak direct, mais combine au tracking precis,
|
||||
profile complet de l'activite hors-projet.
|
||||
|
||||
[ ] Pas de cap sur la frequence des events
|
||||
src/extension.ts:39-49 : `onDidChangeActiveTextEditor` =>
|
||||
chaque alt-tab entre fichiers => 1 POST. Si user est tres
|
||||
actif, 100+ POST par minute. Pas de debounce. Cote
|
||||
monitoringserver, idem aucun rate-limit (cf monitoringserver/
|
||||
todo.txt). Risque d'epuisement bande passante / spam serveur.
|
||||
|
||||
[ ] Le user peut DISABLE l'extension volontairement
|
||||
Standard VSCode : un user peut desactiver toute extension.
|
||||
Le force-install au boot du container la re-active, mais
|
||||
pendant la session, l'employe peut couper le tracking.
|
||||
Pattern de force-tracking discutable (transparency).
|
||||
|
||||
[ ] Pas de TLS pinning sur fetch
|
||||
Si l'URL pointe vers HTTPS (probablement),
|
||||
`monitoringserver.raphaelpiccolo.com`, certificat valide. OK
|
||||
mais pas de pinning.
|
||||
|
||||
BUGS / FRAGILITE
|
||||
----------------
|
||||
[ ] vscodestat-1.1.141.vsix commit dans le repo mais version 1.1.159
|
||||
package.json:4 : "version": "1.1.159" mais le vsix commit est
|
||||
1.1.141. Decalage. Si on installe le vsix, c'est l'ancienne
|
||||
version qui est appliquee (vscode/bin/entrypoint.sh:25 :
|
||||
`code-server --install-extension /opt/vsix/vscodestat.vsix`).
|
||||
A rebuild + republier le vsix avec la version courante.
|
||||
|
||||
[ ] /opt/vsix/vscodestat.vsix : binaire du dossier autre
|
||||
Cf vscode/todo.txt. Le vsix est COPIE dans l'image vscode
|
||||
(Dockerfile:48). Si le vsix de ce repo est modifie mais pas
|
||||
rebuild dans vscode/, decalage permanent.
|
||||
|
||||
[ ] event 'open' sur changement d'onglet, pas vraie ouverture
|
||||
src/extension.ts:39 : `onDidChangeActiveTextEditor`. Fire
|
||||
aussi sur le simple alt-tab entre 2 fichiers deja ouverts.
|
||||
Donc l'event 'open' est mal nomme (en realite "focus de tab").
|
||||
A renommer 'tab_focus' ou similar.
|
||||
|
||||
[ ] event 'focus' sans event name
|
||||
src/extension.ts:55 : `await makeHttpRequest({ focus: event.
|
||||
focused })`. Pas de `event: 'focus'`. Cote serveur, comment
|
||||
distinguer ? Cf monitoringserver/homeController.js:78 :
|
||||
`eventName: req.body.name`. Donc le `focus` event ne match
|
||||
pas la convention serveur.
|
||||
|
||||
[ ] Pas de batching
|
||||
Chaque event = 1 fetch. Pas de queue + flush periodique.
|
||||
Si reseau down, perte d'events (pas de retry). A capper.
|
||||
|
||||
[ ] makeHttpRequest catch silencieux
|
||||
src/extension.ts:114-117 : catch + console.error. Pas de
|
||||
retry, pas de notification user. Si serveur down, events
|
||||
perdus.
|
||||
|
||||
[ ] extractProjectName : path Windows hardcode au regex
|
||||
src/extension.ts:79-80 : replace `\\` -> `/` puis match
|
||||
`/docker/(...)/`. OK pour les conventions /root/docker, mais
|
||||
si project hors `docker/`, retourne null. A clarifier.
|
||||
|
||||
[ ] Pas de tests unitaires sur extractProjectName
|
||||
Function pure, faciles a tester. Pas de tests dans src/test/
|
||||
visible. A check.
|
||||
|
||||
CODE MORT / POLLUTION
|
||||
---------------------
|
||||
[ ] vscodestat-1.1.141.vsix commit
|
||||
Binaire commit dans git. A scrub si rebuild a chaque release.
|
||||
|
||||
[ ] vscodestat.helloWorld command
|
||||
src/extension.ts:7-10. Demo command standard de yeoman.
|
||||
Inutile en prod. A delete.
|
||||
|
||||
CONVENTIONS
|
||||
-----------
|
||||
[ ] Mauvaise pratique : version vsix decalee
|
||||
1.1.141 vs 1.1.159 dans package.json.
|
||||
|
||||
[ ] Pas de README detaille sur l'integration serveur
|
||||
README mentionne juste "Sample url". A documenter le format
|
||||
JSON envoye et le comportement.
|
||||
|
||||
DECISION SUGGEREE
|
||||
-----------------
|
||||
[ ] Rebuild + republier le vsix a la version courante
|
||||
Production decalee de 18 versions (1.1.141 vs 1.1.159).
|
||||
|
||||
[ ] Documenter le scope RGPD du tracking
|
||||
Si l'extension force-installed est obligatoire pour tracker
|
||||
l'activite des employes (Thomas, Luigi), declaration RGPD
|
||||
requise (RGPD art 13).
|
||||
|
||||
[ ] Considerer un rate-limit cote client
|
||||
Debounce sur onDidChangeActiveTextEditor (ex: 1s) pour
|
||||
eviter le spam.
|
||||
Reference in New Issue
Block a user