renovate #32

m.schnitzler · 2025-03-13T05:46:42Z

m.schnitzler commented

2025-03-13 05:46:42 +00:00

npm

lint-staged

^15.4.3 => ^15.5.0 (dvf)

Minor Changes

#1526 630af5f Thanks @iiroj! - Lint-staged no longer resets to the original state when preventing an empty git commit. This happens when your configured tasks reset all the staged changes, typically when trying to commit formatting changes which conflict with your linter setup like ESLint or Prettier.

Example with Prettier

By default Prettier prefers double quotes.

Previously

Stage file.js with only double quotes " changed to '

Run git commit -am "I don't like double quotes"

Lint-staged runs prettier --write file.js, converting all the ' back to "

Because there are now no changes, lint-staged fails, cancels the commit, and resets back to the original state

Commit was not done, original state is restored and single quotes ' are staged

Now

Stage file.js with only double-quotes " changed to '

Run git commit -am "I don't like double quotes"

Lint-staged runs prettier --write file.js, converting all the ' back to "

Because there are now no changes, lint-staged fails and cancels the commit

Commit was not done, and there are no staged changes

<h1>npm</h1> <h2>lint-staged</h2> <ul> <li> ^15.4.3 => ^15.5.0 (dvf)</li> </ul> > <h3>Minor Changes</h3> > <ul> > <li><p><a href="https://github.com/lint-staged/lint-staged/pull/1526">#1526</a> <a href="https://github.com/lint-staged/lint-staged/commit/630af5fb48ed43eb6ccaefa7a9d9612309023b6f"><code>630af5f</code></a> Thanks <a href="https://github.com/iiroj">@iiroj</a>! - Lint-staged no longer resets to the original state when preventing an empty git commit. This happens when your configured tasks reset all the staged changes, typically when trying to commit formatting changes which conflict with your linter setup like ESLint or Prettier.</p> > <h3>Example with Prettier</h3> > <p>By default Prettier <a href="https://prettier.io/docs/rationale#strings">prefers double quotes</a>.</p> > <h4>Previously</h4> > <ol> > <li>Stage <code>file.js</code> with only double quotes <code>"</code> changed to <code>'</code></li> > <li>Run <code>git commit -am "I don't like double quotes"</code></li> > <li><em>Lint-staged</em> runs <code>prettier --write file.js</code>, converting all the <code>'</code> back to <code>"</code></li> > <li>Because there are now no changes, <em>lint-staged</em> fails, cancels the commit, and resets back to the original state</li> > <li>Commit was not done, original state is restored and single quotes <code>'</code> are staged</li> > </ol> > <h4>Now</h4> > <ol> > <li>Stage <code>file.js</code> with only double-quotes <code>"</code> changed to <code>'</code></li> > <li>Run <code>git commit -am "I don't like double quotes"</code></li> > <li><em>Lint-staged</em> runs <code>prettier --write file.js</code>, converting all the <code>'</code> back to <code>"</code></li> > <li>Because there are now no changes, <em>lint-staged</em> fails and cancels the commit</li> > <li>Commit was not done, and there are no staged changes</li> > </ol> > </li> > </ul>

m.schnitzler added 1 commit 2025-03-13 05:46:43 +00:00

fix: "renovate" 85f1628be9

root merged commit 803bc2e35c into master

2025-03-13 07:08:17 +00:00

root referenced this issue from a commit

2025-03-13 07:08:18 +00:00

renovate (#32)

root deleted branch renovate

2025-03-13 07:08:21 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: root/dvf#32